Re: [PATCH] Use BUG_ON(foo) instead of "if (foo) BUG()" in include/asm-i386/dma-mapping.h

From: Adrian Bunk
Date: Sun Aug 06 2006 - 21:22:33 EST

On Sat, Aug 05, 2006 at 11:37:04AM +0000, Pavel Machek wrote:
> Hi!
> > > We have BUG_ON() right for this, don't we?
> >
> > Well yes, but there are over a thousand BUG->BUG_ON conversion
> > possibilities in the tree. If people start sending them three-at-a-time
> > we'll all go mad.
> >
> > So. If we're going to do this, bigger patches, please.
> If we are going that way... I guess we should specify if BUG_ON() has
> to evaluate its arguments even if it is compiled out...

This is already implemented for ages.

> Pavel



"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at