Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes

From: Shem Multinymous
Date: Mon Aug 07 2006 - 12:28:35 EST

Hi Pavel,

On 8/7/06, Pavel Machek <pavel@xxxxxxx> wrote:
> + int total, ret;
> + for (total=READ_TIMEOUT_MSECS; total>0; total-=RETRY_MSECS) {

Could we go from 0 to timeout, not the other way around?

(That's actually vanilla hdapsd code, moved around...)

This actually changes userland interface... but that is probably okay.

Those two sysfs attributes were bogus. If anything used them (which I
very much doubt), it's a good thing we broke it.

OK on the rest.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at