Re: [PATCH 1/10] hot-add-mem x86_64: acpi motherboard fix

From: keith mannthey
Date: Mon Aug 07 2006 - 14:37:20 EST


On Sat, 2006-08-05 at 14:51 +0900, KAMEZAWA Hiroyuki wrote:
> On Fri, 4 Aug 2006 07:13:51 -0600
> Keith Mannthey <kmannth@xxxxxxxxxx> wrote:
> > I have worked to integrate the feedback I recived on the last round of patches
> > and welcome more ideas/advice. Thanks to everyone who has provied input on
> > these patches already.
> >
> Just from review...
>
> If new zone , which was empty at boot, are added into the system.
> build_all_zonelists() has to be called. (see online_pages() in memory_hotplug.c)
> it looks x86_64's __add_pages() doesn't calles it.

With RESERVE there are not empty zones. All zones (including add-areas)
are setup during boot and hot add areas reserved in the bootmem
allocator.

Zones don't change size there is no adding to the zone just on-lining on
pages at are already present in the zone.


--
keith mannthey <kmannth@xxxxxxxxxx>
Linux Technology Center IBM

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/