Re: [-mm patch] add timespec_to_us() and use it in kernel/tsacct.c
From: Adrian Bunk
Date: Mon Aug 07 2006 - 16:43:48 EST
On Mon, Aug 07, 2006 at 01:24:18PM -0700, Andrew Morton wrote:
> On Mon, 7 Aug 2006 15:32:41 +0200
> Adrian Bunk <bunk@xxxxxxxxx> wrote:
> > On Sun, Aug 06, 2006 at 10:21:29PM -0700, Andrew Morton wrote:
> > > On Sun, 6 Aug 2006 23:30:19 -0400
> > > Matt Reuther <mreuther@xxxxxxxxx> wrote:
> > >
> > > > I got an Error while compiling 2.6.18-rc3-mm2:
> > > >
> > > > AR arch/i386/lib/lib.a
> > > > GEN .version
> > > > CHK include/linux/compile.h
> > > > UPD include/linux/compile.h
> > > > CC init/version.o
> > > > LD init/built-in.o
> > > > LD .tmp_vmlinux1
> > > > kernel/built-in.o(.text+0x45667): In function `bacct_add_tsk':
> > > > include/linux/time.h:130: undefined reference to `__divdi3'
> > > > make: *** [.tmp_vmlinux1] Error 1
> > > >
> > > > I attached the .config file.
> > > >
> > >
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc3/2.6.18-rc3-mm2/hot-fixes/csa-basic-accounting-over-taskstats-fix.patch
> > > should fix this, thanks.
> > This doesn't look correct since do_div() does not guarantee to return
> > more than 32bit.
> eh? We use do_div() to do 64bit/something all the time??
Sorry, this was my thinko.
> > What about the patch below that adds a timespec_to_us() to time.h and
> > uses this function in kernel/tsacct.c?
> Seems reasonable, but it'd be better as two patches..
Feel free to split this patch however you want, I thought it was not
worth splitting it.
> Do we do timespec->microseconds anywhere else?
I haven't found another place.
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/