Re: [PATCH 02/12] hdaps: Use thinkpad_ec instead of direct port access

From: Pavel Machek
Date: Mon Aug 07 2006 - 19:20:09 EST


> >> +#define ABORT_INIT(msg) { printk(KERN_ERR "hdaps init: %s\n", msg);
> >goto bad; }
> >
> >No.. macro with embedded goto is *evil*.
> OK. But it does makes the init function much longer and harder to

If you keep { printk(); goto } on one line... it is technically
codingstyle violation but it is certainly better than evil macro.

> >> + if (data.val[0xF]!=0x00)
> >> + ABORT_INIT("check1");
> >
> >!=0 in if is evil...
> Sure, when zero is special, like for booleans or integer or pointers.
> But this is a status byte value, I don't want to mistreat it just
> because all its bits are unset. Otherwise, imagine the non-systematic
> mess this will become:

Okay, I'd only do it in "single" cases. I guess you have point about
unsigned char not being boolean.
(cesky, pictures)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at