Re: [PATCH 01/12] thinkpad_ec: New driver for ThinkPad embedded controller access

From: Pavel Machek
Date: Tue Aug 08 2006 - 05:37:18 EST


> >Okay... but do we really need try_lock variant?
> We need a nonlocking, nonsleeping variant to do the query in the timer
> function (softirq context).
> >but what is try_lock semantics when taking multiple locks...?
> Currently, the same as the undelying down_trylock().

Okay, I guess this works for me.

> >Well, this will also trigger for thinkpad module compiled into kernel,
> >right?
> OK, I'm changing the DMI failure to KERN_WARNING. Subsequent hardware
> checks remains KERN_ERR, since failing those after passing the DMI
> check really is abnormal (and indicative of danger).

Yep, that sounds correct.
(cesky, pictures)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at