Re: [PATCH 03/12] hdaps: Unify and cache hdaps readouts

From: Shem Multinymous
Date: Tue Aug 08 2006 - 06:03:42 EST

On 8/8/06, Pavel Machek <pavel@xxxxxxx> wrote:
/* Parse position data: */
x = *(s16*)(data.val+EC_ACCEL_IDX_XPOS1);
y = *(s16*)(data.val+EC_ACCEL_IDX_YPOS1);
transform_axes(&x, &y);

...which looks even better to me.

Yes, that's elegant.
But it made me realize there's a race condition here (and and also in
the mainline driver): the global pos_x, rest_x etc. could be updated
while an attribute's show_* function is called. Ugh. I guess I need to
sprinkle spinlocks all over the place.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at