Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes

[Shem Multinymous]

Hi Muli,

On 8/8/06, Muli Ben-Yehuda <muli@xxxxxxxxxx> wrote:
> > > >   ret = thinkpad_ec_lock();
> > > >   if (ret)
> > > >           return ret;

> Ugh, I missed that - it's called _lock(), but it's actually
> down_interruptible().

Why is that confusing?

> Why not just get rid of the wrapper and call
> down_interruptible() directly? That makes it obvious what's going on.

We may end up needing to lock away other subsystems (ACPI?) that
touch the same ports. Apparently not an issue right now, but could
change with new firmware. (http://lkml.org/lkml/2006/8/7/147)

 Shem
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/