Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes

From: Shem Multinymous
Date: Tue Aug 08 2006 - 09:33:01 EST

Hi Muli,

On 8/8/06, Muli Ben-Yehuda <muli@xxxxxxxxxx> wrote:
> > > ret = thinkpad_ec_lock();
> > > if (ret)
> > > return ret;

Ugh, I missed that - it's called _lock(), but it's actually

Why is that confusing?

Why not just get rid of the wrapper and call
down_interruptible() directly? That makes it obvious what's going on.

We may end up needing to lock away other subsystems (ACPI?) that
touch the same ports. Apparently not an issue right now, but could
change with new firmware. (

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at