Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes

From: Muli Ben-Yehuda
Date: Tue Aug 08 2006 - 09:41:19 EST

On Tue, Aug 08, 2006 at 04:35:23PM +0300, Shem Multinymous wrote:
> Hi Muli,
> On 8/8/06, Muli Ben-Yehuda <muli@xxxxxxxxxx> wrote:
> >> > > ret = thinkpad_ec_lock();
> >> > > if (ret)
> >> > > return ret;
> >Ugh, I missed that - it's called _lock(), but it's actually
> >down_interruptible().
> Why is that confusing?

lock() sounds like spin_lock() to me, and spin_lock() can't
fail. Idiomatic code is easier for my brain to parse.

> >Why not just get rid of the wrapper and call
> >down_interruptible() directly? That makes it obvious what's going on.
> We may end up needing to lock away other subsystems (ACPI?) that
> touch the same ports. Apparently not an issue right now, but could
> change with new firmware. (

When (if) it becomes necessary to lock away other subsystems, the
wrapper can be easily reintroduced.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at