Re: [PATCH 02/06] i386: remove redundant generic_identify() calls when identifying cpus
From: Andi Kleen
Date: Tue Aug 08 2006 - 22:18:09 EST
On Wednesday 09 August 2006 03:03, Magnus Damm wrote:
> i386: remove redundant generic_identify() calls when identifying cpus
> cpu_dev->c_identify is only called from arch/i386/common.c:identify_cpu(), and
> this after generic_identify() already has been called. There is no need to call
> this function twice and hook it in c_identify - but I may be wrong, please
> double check before applying.
> This patch also removes generic_identify() from cpu.h to avoid unnecessary
> future nesting.
There are sometimes subtle interactions with this (e.g. with parameters
changing flags and then someone else overwriting them again)
But agreed it seems bogus to call it twice.
I guess the only way to find out how much it breaks is to merge it.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/