Re: [RFC][PATCH 2/6] x86_64: hpet_address cleanup

From: john stultz
Date: Tue Aug 08 2006 - 23:07:20 EST

On Wed, 2006-08-09 at 04:31 +0200, Andi Kleen wrote:
> On Wednesday 09 August 2006 04:17, john stultz wrote:
> > In preparation for supporting generic timekeeping, this patch cleans up
> > x86-64's use of vxtime.hpet_address, changing it to just hpet_address
> > as is also used in i386. This is necessary since the vxtime structure
> > will be going away.
> Does the kernel still boot with that patch only?

Just tested, and yes it still boots, but my box doesn't have HPET so
that isn't much of a test. :(

As I said in the announce mail, I've not boot tested each step, I
suspect patches 4/6 and 5/6 will have troubles (vsyscall isn't disabled,
but the updating is). I'll try to address that in the next release.

> Your new variable doesn't seem to be exported to vsyscalls

The vxtime structure hasn't yet been removed and we set
vxtime.hpet_address = hpet_address in necessary spots, so it should be


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at