Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes

From: Shem Multinymous
Date: Wed Aug 09 2006 - 05:00:19 EST

On 8/9/06, Muli Ben-Yehuda <muli@xxxxxxxxxx> wrote:
> >If the concern is just the naming then change it to end _trylock
> We already have a thinkpad_ec_trylock() for the non-blocking
> variant.


Just ran out, of that sir,

If we'll need to lock away ACPI (just matter of time, my guess), we'll
stumble upon the non-interruptible down()s deep inside in the ACPI
code. So we can't guarantee and shouldn't promise it's really

It's not that strange that a function might fail even if it's named
"do_something()", you know. It's down() that forms an exception - it's
so simple we know it can't fail.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at