Re: [patch] i386: annotate the rest of entry.s::nmi
From: Andi Kleen
Date: Thu Aug 10 2006 - 08:56:49 EST
On Thursday 10 August 2006 14:48, Chuck Ebbert wrote:
> In-Reply-To: <44DB0927.76E4.0078.0@xxxxxxxxxx>
> On Thu, 10 Aug 2006 10:23:35 +0200, Jan Beulich wrote:
> > >Part of the NMI handler is missing annotations. Just moving
> > >the RING0_INT_FRAME macro fixes it. And additional comments
> > >should warn anyone changing this to recheck the annotations.
> > I have to admit that I can't see the value of this movement; the
> > code sequence in question was left un-annotated intentionally.
> > The point is that the push-es in FIX_STACK() aren't annotated, so
> > things won't be correct at those points anyway.
> I have a patch here that adds that, but it won't compile
> because that part of the NMI handler is un-annotated:
Ok i dropped the original patch for now and you guys can work
out a correct fix.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/