Re: [patch] i386: annotate the rest of entry.s::nmi
From: Jan Beulich
Date: Thu Aug 10 2006 - 09:36:17 EST
>> >Part of the NMI handler is missing annotations. Just moving
>> >the RING0_INT_FRAME macro fixes it. And additional comments
>> >should warn anyone changing this to recheck the annotations.
>> I have to admit that I can't see the value of this movement; the
>> code sequence in question was left un-annotated intentionally.
>> The point is that the push-es in FIX_STACK() aren't annotated, so
>> things won't be correct at those points anyway.
>I have a patch here that adds that, but it won't compile
>because that part of the NMI handler is un-annotated:
But you didn't clarify why you need this piece of code annotated...
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/