Re: [PATCH 1/1] scsi : megaraid_{mm, mbox} : irq data type fix

[James Bottomley]

On Thu, 2006-08-10 at 12:54 -0400, Seokmann Ju wrote:
> This patch fixes incorrect irq data type in the driver which led driver initialization failure in some cases.
> The problem was reported by Eric @. Biederman <ebiederm@xxxxxxxxxxxx>.
[...]
> 	uint32_t		unique_id;
> -	uint8_t			irq;
> +	unsigned int		irq;
>  	uint8_t			ito;

This doesn't look right ... you're altering the size of a packed field
within the ioctl body.  This will break the ioctl ABI (and thus all
tools which use it) unless you employ versioning or some other mechanism
to detect the breakage and compensate.  I really don't think you want to
do this.

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/