Re: [Ext2-devel] [PATCH 1/9] extents for ext4
From: Alex Tomas
Date: Thu Aug 10 2006 - 15:01:37 EST
>>>>> Randy Dunlap (RD) writes:
RD> On Thu, 10 Aug 2006 13:29:56 +0400 Alex Tomas wrote:
>> >>>>> Andrew Morton (AM) writes:
>> >> From a quick scan:
AM> - The code is very poorly commented. I'd want to spend a lot of time
AM> reviewing this implementation, but not in its present state.
>> what sort of comments are you expecting?
RD> Helpful ones. Not obvious stuff. Intents.
RD> Tricks used (if they are the right thing to do).
RD> How, what, why. But not nitty-gritty details of how.
RD> "Why" is often more important.
well, it's a simple b+tree and i'm not sure there are ticks in.
I'll try to re-read them again WRT what you wrote.
AM> - The existing comments could benefit from some rework by a native English
>> could someone assist here, please?
RD> Yes. How would you like it? Just comments via email or (quilt) patches?
RD> Which files/patches?
please, have a look at ext4-extents.patch first
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/