Re: [PATCH 2/9] sector_t format string
From: Jeff Mahoney
Date: Thu Aug 10 2006 - 16:14:49 EST
-----BEGIN PGP SIGNED MESSAGE-----
Alexey Dobriyan wrote:
> On Thu, Aug 10, 2006 at 12:17:47PM -0700, Joel Becker wrote:
>> On Wed, Aug 09, 2006 at 11:40:19PM -0700, Andrew Morton wrote:
>>> On Wed, 09 Aug 2006 18:20:43 -0700
>>> Mingming Cao <cmm@xxxxxxxxxx> wrote:
>>>> Define SECTOR_FMT to print sector_t in proper format
>>> We've thus-far avoided doing this. In fact a similar construct in
>>> device-mapper was recently removed.
>> Yeah, OCFS2 had similar formats, and we were asked to change
>> them to naked casts before inclusion. Seems quite consistent with the
>> rest of the kernel.
> printk("%S", sector_t);
> kill at least one kitten?
I like the general idea. I think that having to cast every time you want
to print a sector number is pretty gross. I had something more like %Su
in mind, though.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/