[PATCH for review] [21/145] x86_64: kdump x86_64 nmi event notification fix

From: Andi Kleen
Date: Thu Aug 10 2006 - 16:36:53 EST


From: Vivek Goyal <vgoyal@xxxxxxxxxx>

After a crash we should wait for NMI IPI event and not for external NMI or
NMI watchdog tick.

Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
Signed-off-by: Andi Kleen <ak@xxxxxxx>
Cc: Don Zickus <dzickus@xxxxxxxxxx>
Cc: Andi Kleen <ak@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>

arch/x86_64/kernel/crash.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

Index: linux/arch/x86_64/kernel/crash.c
--- linux.orig/arch/x86_64/kernel/crash.c
+++ linux/arch/x86_64/kernel/crash.c
@@ -102,7 +102,7 @@ static int crash_nmi_callback(struct not
struct pt_regs *regs;
int cpu;

- if (val != DIE_NMI)
+ if (val != DIE_NMI_IPI)
return NOTIFY_OK;

regs = ((struct die_args *)data)->regs;
@@ -114,7 +114,7 @@ static int crash_nmi_callback(struct not
* an NMI if system was initially booted with nmi_watchdog parameter.
if (cpu == crashing_cpu)
- return 1;
+ return NOTIFY_STOP;

crash_save_this_cpu(regs, cpu);
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/