Re: [PATCH 00/12] ThinkPad embedded controller and hdaps drivers (version 2)

From: Jesper Juhl
Date: Thu Aug 10 2006 - 19:09:34 EST


On 10/08/06, Jean Delvare <khali@xxxxxxxxxxxx> wrote:
All,

> On Thu, Aug 10, 2006 at 01:18:20PM -0700, Andrew Morton wrote:
> > On Thu, 10 Aug 2006 09:46:47 -0400
> > "Robert Love" <rlove@xxxxxxxxx> wrote:
> >
> > > Patches look great and I am glad someone has apparently better access
> > > to hardware specs than I did.
> >
> > This situation is still a concern. From where did this additional register
> > information come?
> >
> > Was it reverse-engineered? If so, by whom and how can we satisfy ourselves
> > of this?
> >
> > Was it from published documents?
> >
> > Was it improperly obtained from NDA'ed documentation?
> >
> > Presumably the answer to the third question will be "no", but if
> > challenged, how can we defend this assertion?
> >
> > So hm. We're setting precedent here and we need Linus around to resolve
> > this. Perhaps we can ask "Shem" to reveal his true identity to Linus (and
> > maybe me) privately and then we proceed on that basis. The rule could be
> > "each of the Signed-off-by:ers should know the identity of the others".
>
> For what it's worth, I'm not going to be handling these patches at all
> (normally the hwmon patches go to Linus through Jean and then through
> me.)

I said it in private before, and I say it publicly again: I am not
handling these patches either. I don't even want to read them.

> If the original developer does not want to work in the open like the
> rest of us, I can respect that, but unfortunatly I can't accept the risk
> of accepting their code.
>
> And no, this is not "been beaten over the head by IP lawyers for three
> years about risks like this" portion of me talking, although that side
> does have a lot he could say about this situation...

As far as I am concerned, even the real name of the person who wrote
and sent these patches wouldn't be enough for me to take them. I would
ask for an explanation of how that person got access to information
about the HDAPS which even the original author of the driver didn't
know about. And I would ask for proofs of that explanation.


As the person who wrote the initial version of the driver (not the
only one, other people wrote versions at the same time, but mine was
the one that was the basis for what Robert took over and what got
merged in mainline) I'd also be interrested in where this person got
his/her info from. I looked long and hard for docs and send lots of
emails to IBM and others requesting info (unsuccessfully), all I could
ever find was http://www.almaden.ibm.com/cs/people/marksmith/tpaps.html
which is then what I used to write the initial driver from.


All this is very unlikely to happen as I understand it, and anyway it's
all too late. Regardless of its technical merits, this patchset has too
much legal uncertainty attached to it by now. I'm maintaining the hwmon
subsystem on my own time and money, it's painful and unrewarding enough
as it is without adding legal hazard into the picture.

Maybe if the person behind these patches could do the following

1) Come out with his/her real name.
2) Provide detailed information about what sources of info these
patches are based on.
3) Provide names and contact info for people at IBM/Lenovo/the company
who made the gyroscope (can't remember who they are) etc etc, so that
we can contact them and verify these patches are based on stuff that's
OK.

then we could accept the patches...


--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/