Re: [PATCH for review] [130/145] i386: clean up topology.c

From: Magnus Damm
Date: Thu Aug 10 2006 - 21:37:35 EST

On 8/11/06, Dave Hansen <haveblue@xxxxxxxxxx> wrote:
On Thu, 2006-08-10 at 21:37 +0200, Andi Kleen wrote:
> static int __init topology_init(void)
> {
> int i;
> +#ifdef CONFIG_NUMA
> for_each_online_node(i)
> register_one_node(i);
> +#endif /* CONFIG_NUMA */
> for_each_present_cpu(i)
> arch_register_cpu(i);
> return 0;
> }

Wouldn't it be more proper here to make register_one_node() have a
non-NUMA definition, instead of putting an #ifdef in a .c file like

I thought about that too, and my reason for not doing it is that this
simple fix would be less straight-forward and probably more subject to
whining and arguing. So my plan was to do this as a first step and
then encourage anyone else that wanted to fix up register_one_node()
properly. =)


/ magnus
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at