Re: [patch 6/6] Move per-device data out of backlight_properties

From: Dmitry Torokhov
Date: Fri Aug 11 2006 - 08:25:37 EST

On 8/11/06, Richard Purdie <rpurdie@xxxxxxxxx> wrote:
On Fri, 2006-08-11 at 01:03 -0400, Dmitry Torokhov wrote:
> plain text document attachment (backlight-move-data.patch)
> Backlight: move per-device data out of backlight_properties
> Data such as current brightness belongs to a device and should not
> be part of a structure shared between several devices.

I agree there's an issue to address here. Looking at this patch very
quickly, it breaks all the existing backlight drivers as they know about
the variables in struct backlight_properties and all their references
need to be updated e.g.: corgi_bl.c:

if (bd->props->power != FB_BLANK_UNBLANK)
intensity = 0;
if (bd->props->fb_blank != FB_BLANK_UNBLANK)
intensity = 0;

Oops, I had them all updated but apparently lost that change. I'll fix
it and resend.

Thinking about this, ideally, struct backlight_properties would be left
containing the backlight properties in but become part of struct
backlight_device (and allocated with it).

Why would you want to separate properties into a structure? You don't
normally pass a set of properties around so I am not sure why would we
need this...

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at