Re: question about kill PIDTYPE_TGID patch

[Eric W. Biederman]

Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:

> On Wed, Aug 09, 2006 at 01:23:12PM +0200, merlin@xxxxxxxxx wrote:
>> Hello,
>> 
>> I'm trying to compile IBM GPFS(2.3.0-15) Portability Layer with a 2.6.16 
>> kernel (2.6.16-1.2289_FC6-xen-i686). The compiler stops with 
>> the error message below:
>> 
>> kdump-kern.c:163: error: `PIDTYPE_TGID' undeclared (first use in this 
>> function)
>> 
>> As I think, this is because of the PIDTYPE_TGID patch. 
>> 
>> I don't want to get out that patch from the kernel , if there's
>> a more simple solution.
>> 
>> I hope you can suggest me a solution for the three lines where PIDTYPE_TGID
>> appears (see below) in the source code.
>
> Just stop using broken, propritary out of tree code.  If you refuse to
> do that go to your IBM support contact and whine to them, it's their fault
> after all.

What makes this very funny is that if the GPFS code had called the appropriate
function it would not have broken.  The appropriate function is the same
in 2.4.x as it is in 2.6.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/