Re: aic7xxx broken in 2.6.18-rc3-mm2

[Daniel Ritz]

On Monday 14 August 2006 19.16, Dave Hansen wrote:
> On Mon, 2006-08-14 at 18:58 +0200, Daniel Ritz wrote:
> > hmm..should be 2.6.16 behavior with this...
> > what kind of box is this?
> 
> I know my earlier description was vague.  Please let me know if there
> are any specifics you need.

thanks, for the info.

> 
> > could you give me dmesg output of plain 2.6.18-rc4
> 
> http://sr71.net/~dave/linux/daniel.ritz/dmesg-elm3b82-2.6.18-rc4.txt
> 
> > and a 2.6.18-rc4 with the patch (not -mm if possible)?
> 
> http://sr71.net/~dave/linux/daniel.ritz/dmesg-elm3b82-2.6.18-rc4-with-gregkh-pci-pci-use-pci_bios-as-last-fallback.txt
> 
> > oh...and a lspci -vvv please
> 
> http://sr71.net/~dave/linux/daniel.ritz/lspci-vvv-elm3b82.txt
> 
> (A reversed copy of) the patch I applied to 2.6.18-rc4 is in that
> directory, too:
> 
> http://sr71.net/~dave/linux/daniel.ritz/gregkh-pci-pci-use-pci_bios-as-last-fallback.patch

errm...sorry, i didn't mean that patch but the alternative i sent later. attached.
it should use direct access while not breaking legacy PCI probing. in theory..

thanks,
-daniel

diff --git a/arch/i386/pci/init.c b/arch/i386/pci/init.c
index c7650a7..51087a9 100644
--- a/arch/i386/pci/init.c
+++ b/arch/i386/pci/init.c
@@ -14,8 +14,12 @@ #endif
 #ifdef CONFIG_PCI_BIOS
 	pci_pcbios_init();
 #endif
-	if (raw_pci_ops)
-		return 0;
+	/*
+	 * don't check for raw_pci_ops here because we want pcbios as last
+	 * fallback, yet it's needed to run first to set pcibios_last_bus
+	 * in case legacy PCI probing is used. otherwise detecting peer busses
+	 * fails.
+	 */
 #ifdef CONFIG_PCI_DIRECT
 	pci_direct_init();
 #endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/