drivers/acpi/sbs.c:acpi_sbs_remove() inconsistent NULL checking

From: Adrian Bunk
Date: Mon Aug 14 2006 - 18:46:13 EST

The Coverity checker spotted the following inconsistent NULL checking
introduced by commit 3f86b83243d59bb50caf5938d284d22e10d082a4:

<-- snip -->

int acpi_sbs_remove(struct acpi_device *device, int type)
struct acpi_sbs *sbs = (struct acpi_sbs *)acpi_driver_data(device);
int id;

if (!device || !sbs) {
return -EINVAL;

<-- snip -->

The NULL check for "device" is three lines after it got dereferenced the
first time.



Gentoo kernels are 42 times more popular than SUSE kernels among
KLive users (a service by SUSE contractor Andrea Arcangeli that
gathers data about kernels from many users worldwide).

There are three kinds of lies: Lies, Damn Lies, and Statistics.
Benjamin Disraeli

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at