Re: [Patch] Signdness issue in drivers/scsi/osst.c

[Alan Cox]

Ar Sad, 2006-08-19 am 21:19 +0200, ysgrifennodd Eric Sesterhenn:
> Hi,
> 
> another signdness warning from gcc 4.1
> 
> drivers/scsi/osst.c:5154: warning: comparison of unsigned expression < 0 is always false
> 
> The problem is that blk is defined as unsigned, but all usages of it
> are normal int cases. osst_get_frame_position() and osst_get_sector()
> return ints and can return negative values. If blk stays an unsigned int,
> the error check is useless.


Acked-by: Alan Cox <alan@xxxxxxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/