Re: [PATCH] Signdness issue in drivers/video/intelfb/intelfbdrv.c
From: Dave Airlie
Date: Mon Aug 21 2006 - 20:12:40 EST
On 8/21/06, Eric Sesterhenn <snakebyte@xxxxxx> wrote:
hi,
another gcc 4.1 signess warning:
drivers/video/intelfb/intelfbdrv.c:419: warning: comparison of unsigned expression < 0 is always false
since dinfo->mtrr_reg is of the type u32, the error check dinfo->mtrr_reg < 0
is useless. This patch introduces a helper variable, which catches possible
negative error values returned by mtrr_add()
Signed-off-by: Eric Sesterhenn <snakebyte@xxxxxx>
NAK.
I've applied a much simpler fix to use make mtrr_reg an int to my
intelfb tree....
Dave.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/