Re: 2.6.18-rc4-mm2: x86_64 compile error

From: Jan Beulich
Date: Tue Aug 22 2006 - 04:08:54 EST


>>> Adrian Bunk <bunk@xxxxxxxxx> 21.08.06 23:21 >>>
>On Sat, Aug 19, 2006 at 10:00:08PM -0700, Andrew Morton wrote:
>>...
>> Changes since 2.6.18-rc4-mm1:
>>...
>> +x86_64-mm-fix-x86-cpuid-keys-used-in-alternative_smp.patch
>>...
>> x86_64 tree updates
>>...
>
>This patch causes the following compile error (cross compiling from i386
>using gcc 4.1):
>
><-- snip -->
>
>...
> LD .tmp_vmlinux1
>kernel/built-in.o:(.smp_altinstructions+0x10): undefined reference to `X86_FEATURE_UP'
>kernel/built-in.o:(.smp_altinstructions+0x28): undefined reference to `X86_FEATURE_UP'
>kernel/built-in.o:(.smp_altinstructions+0x40): undefined reference to `X86_FEATURE_UP'
>kernel/built-in.o:(.smp_altinstructions+0x58): undefined reference to `X86_FEATURE_UP'
>make[1]: *** [.tmp_vmlinux1] Error 1

Odd - asm/cpufeature.h is being included by asm/processor.h, which is included by
linux/sched.h, which in turn I would have assumed is included by virtually everything.
The simply solution would be to explicitly include it from asm/alternative.h - could you
give that a try? Regardless of that I'd be curious what source file under kernel/ (and
perhaps with what .config) neither includes linux/sched.h nor asm/processor.h.

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/