Re: [PATCH -mm] x86_64: Adjust the timing of initializing cyc2ns_scale.

From: Andi Kleen
Date: Fri Aug 25 2006 - 12:53:22 EST


On Friday 25 August 2006 18:45, Toyo Abe wrote:
> The x86_64-mm-monotonic-clock.patch in 2.6.18-rc4-mm2 made a change to
> the updating of monotonic_base. It now uses cycles_2_ns().
>
> I suggest that a set_cyc2ns_scale() should be done prior to the setup_irq().
> Because cycles_2_ns() can be called from the timer ISR right after the irq0
> is enabled.

Added thanks. I folded it into the original patch.

Did you actually see a failure or was this just from code review?
-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/