Re: another NUMA build error

From: KAMEZAWA Hiroyuki
Date: Fri Aug 25 2006 - 14:30:07 EST


On Fri, 25 Aug 2006 10:35:07 -0700
"Randy.Dunlap" <rdunlap@xxxxxxxxxxxx> wrote:

> OK, I prefer option 2 because it is more generic (not hardware-
> specific). Someone else can prefer option 1 because it is
> hardware-specific. :)
>
ok. patch is here. but people who know x86-numa should confirm this.

-Kame
--
compile fix for

In file included from include/asm/mmzone.h:18,
from include/linux/mmzone.h:439,
<snip>
include/asm/srat.h:31:2: error: #error CONFIG_ACPI_SRAT not defined, and srat.h header has been included
make[1]: *** [arch/i386/kernel/asm-offsets.s] Error 1

This can happen with CONFIG_NUMA && !CONFIG_ACPI && !CONFIG_X86_NUMAQ

Signed-Off-By: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>

include/asm-i386/mmzone.h | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.18-rc4/include/asm-i386/mmzone.h
===================================================================
--- linux-2.6.18-rc4.orig/include/asm-i386/mmzone.h
+++ linux-2.6.18-rc4/include/asm-i386/mmzone.h
@@ -14,7 +14,7 @@ extern struct pglist_data *node_data[];

#ifdef CONFIG_X86_NUMAQ
#include <asm/numaq.h>
-#else /* summit or generic arch */
+#elif defined(CONFIG_ACPI_SRAT)/* summit or generic arch */
#include <asm/srat.h>
#endif


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/