Re: Is stopmachine() preempt safe?

[Rusty Russell]

On Sun, 2006-08-27 at 19:42 +1000, Keith Owens wrote:
> I cannot convince myself that stopmachine() is preempt safe.  What
> prevents this race with CONFIG_PREEMPT=y?

Nothing.  Read side is preempt_disable.  Write side is stopmachine.

I wrote it that way to avoid having to touch the scheduler.  A bigger
stopmachine is possible which schedules all preempted tasks; my plan is
to write such a thing shortly, to see what it looks like.

Cheers,
Rusty.
-- 
Help! Save Australia from the worst of the DMCA: http://linux.org.au/law

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/