Re: [patch] fix up smp alternatives on x86-64

From: Andi Kleen
Date: Mon Aug 28 2006 - 05:19:54 EST


On Monday 28 August 2006 11:20, Gerd Hoffmann wrote:
> Don't use alternative_smp() in for __raw_spin_lock. gcc
> sometimes generates rip-relative addressing, so we can't
> simply copy the instruction to another place.
>
> Replace some leftover "lock;" with LOCK_PREFIX.
>
> Fillup space with 0x90 (nop) instead of 0x42, so
> "objdump -d -j .smp_altinstr_replacement vmlinux" gives more
> readable results.

I already fixed it myself.

ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/remove-alternative-smp
ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/i386-remove-alternative-smp

And all the left over lock prefixes are also gone in that tree.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/