Re: [PATCH 000 of 2] Invalidate_inode_pages2 changes.

[Neil Brown]

On Monday August 28, akpm@xxxxxxxx wrote:
> On Tue, 29 Aug 2006 11:30:15 +1000
> NeilBrown <neilb@xxxxxxx> wrote:
> 
> >  I'm picking up on a conversation that was started in late March
> >  this year, and which didn't get anywhere much.
> >  See
> >    http://lkml.org/lkml/2006/3/31/93
> >  and following.
> 
> Nick's "possible lock_page fix for Andrea's nopage vs invalidate race?"
> patch (linux-mm) should fix this?
> 
> If filemap_nopage() does lock_page(), invalidate_inode_pages2_range() is solid?

UHmm.... yes.  In that case we can remove lots of stuff from
invalidate_inode_pages2_range as we can be sure the page won't be
dirty or in writeback so invalidate_complete_page will be certain to
succeed. 

So if that goes ahead, these become moot.  But until it does, these
would be nice to have :-)

Also, the patch at
  http://marc.theaimsgroup.com/?l=linux-mm&m=115443228617576&w=2
appears not to set 
  +	.vm_flags	= VM_CAN_INVLD,
for nfs_fs_vm_operations, but maybe they are a later addition to
nfs...

Thinks: should I subscribe to linux-mm... only about 100 messages per
week.... maybe :-)

Thanks,
NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/