Re: [PATCH RESEND] sys_ioprio_set: don't disable irqs

From: Jens Axboe
Date: Tue Aug 29 2006 - 03:11:37 EST


On Sun, Aug 27 2006, Oleg Nesterov wrote:
> It is not good to disable interrupts while traversing all tasks in the system.
> As I see it, sys_ioprio_get() doesn't need to do it at all, sys_ioprio_set()
> does it for cfq_ioc_set_ioprio(), the latter can disable irqs itself.
>
> Also, add a comment to explain why do we need tasklist_lock.
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

You should work against the 'block' branch in the block git repo, things
tend to change... I've applied your ioprio.c bit, the other one is not
needed anymore.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/