[PATCH] nsproxy cloning error path fix

From: Pavel
Date: Thu Aug 31 2006 - 06:19:51 EST


This patch fixes copy_namespaces()'s error path.

when new nsproxy (new_ns) is created pointers to namespaces (ipc, uts)
are copied from the old nsproxy. Later in copy_utsname, copy_ipcs, etc.
according namespaces are get-ed. On error path needed namespaces are
put-ed, so there's no need to put new nsproxy itelf as it woud cause
putting namespaces for the second time.

Found when incorporating namespaces into OpenVZ kernel.

Signed-off-by: Pavel Emelianov <xemul@xxxxxxxxxx>
---

nsproxy.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

--- ./kernel/nsproxy.c.veboot 2006-08-30 17:48:59.000000000 +0400
+++ ./kernel/nsproxy.c 2006-08-31 10:54:56.000000000 +0400
@@ -115,7 +115,7 @@ out_uts:
put_namespace(new_ns->namespace);
out_ns:
tsk->nsproxy = old_ns;
- put_nsproxy(new_ns);
+ kfree(new_ns);
goto out;
}



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/