Re: [PATCH 01/16] GFS2: Core header files

[Jan Engelhardt]

>> 
>or you could argue that the addition of a space (i.e. v. 2) would be
>correct since its an abbreviation, but point taken and I'll clean it up
>shortly.

Or spell it out, as in many GPL headers.

>> >+	/* Quota stuff */
>> >+
>> >+	struct gfs2_quota_data *al_qd[4];
>> 
>> What four quotas can there be? Use the MAXQUOTAS macro if feasible.
>> 
>[...]
>As a result there are the overall user/group limits and the local
>differences which are saved to by synced back to the master quota
>information, hence four of them.

Well, al_qd[2*MAXQUOTAS] then.


Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/