Re: [PATCH 08/22][RFC] Unionfs: Directory manipulation helperfunctions

[Jan Engelhardt]

>+/* This filldir function makes sure only whiteouts exist within a directory. */
>+static int readdir_util_callback(void *dirent, const char *name, int namelen,
>+				 loff_t offset, ino_t ino, unsigned int d_type)
>+{
>+	int err = 0;
>+	struct unionfs_rdutil_callback *buf =
>+	    (struct unionfs_rdutil_callback *)dirent;

Nocast.

>+	if ((namelen > UNIONFS_WHLEN) && !strncmp(name, UNIONFS_WHPFX, UNIONFS_WHLEN)) {
()
Also elsewhere.

>+	if (0 <= bopaque && bopaque < bend)

Turn it. Constant values are usually wanted on the right side.

	bopaque >= 0



Jan Engelhardt
-- 

-- 
VGER BF report: H 1.55431e-15
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/