Re: [PATCH] lockdep: disable lock debugging when kernel state becomesuntrusted

From: Arjan van de Ven
Date: Tue Sep 05 2006 - 03:07:40 EST


Andrew Morton wrote:
On Tue, 5 Sep 2006 08:40:42 +0200
Voluspa <lista1@xxxxxxxxx> wrote:

That would appear to be a bug. debug_locks_off() is running
console_verbose() waaaay after the locking selftest code has
completed.
The possibly final -rc6 is likewise broken. What would it take to incur
some respect for us, the millions of users effected by this shit?
Should we all become quasi-developers and bombard lkml with patches
that taint the kernel whenever some of the Intel binary blobs are
loaded?

don't use those btw, they're ancient and unneeded/superceded since ages.


Would that cluebat Arjan off of his high horse?

Thanks for the reminder ;)

Arjan, what's that console_verbose() doing in debug_locks_off()? Whatever
it is, can we fix it? Presumably the previous loglevel needs to be
readopted somehow, or we just take it out of there.

I'd say take them out of there; I don't know why they're there in the first place.. Ingo ?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/