Re: [PATCH] x86 microcode: don't check the size

From: Jeff Garzik
Date: Thu Sep 07 2006 - 00:32:00 EST


Shaohua Li wrote:
IA32 manual says if micorcode update's size is 0, then the size is
default size (2048 bytes). But this doesn't suggest all microcode
update's size should be above 2048 bytes to me. We actually had a
microcode update whose size is 1024 bytes. The patch just removed the
check.

Signed-off-by: Shaohua Li <shaohua.li@xxxxxxxxx>

Why not explicitly check for zero, rather than removing the questionable less-than test? The default size logic hasn't disappeared...

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/