Re: [PATCH 1/5] proc: Make the generation of the self symlink tabledriven.

[Andrew Morton]

On Wed, 06 Sep 2006 10:23:00 -0600
ebiederm@xxxxxxxxxxxx (Eric W. Biederman) wrote:

> 
> This patch generalizes the concept of files in /proc that are
> related to processes but live in the root directory of /proc
> 
> Ideally this would reuse infrastructure from the rest of the
> process specific parts of proc but unfortunately
> security_task_to_inode must not be called on files that
> are not strictly per process.  security_task_to_inode
> really needs to be reexamined as the security label can
> change in important places that we are not currently
> catching, but I'm not certain that simplifies this problem.
> 
> By at least matching the structure of the rest of proc
> we get more idiom reuse and it becomes easier to spot problems
> in the way things are put together.
> 
> Later things like /proc/mounts are likely to be moved into
> proc_base as well.  If union mounts are ever supported
> we may be able to make /proc a union mount, and properly
> split it into 2 filesystems.
> 
> ..
>
>  /*
> + * proc base
> + *
> + * These are the directory entries in the root directory of /proc
> + * that properly belong to the /proc filesystem, as they describe
> + * describe something that is process related.
> + */
> +static struct pid_entry proc_base_stuff[] = {
> +	NOD(PROC_TGID_INO, 	"self", S_IFLNK|S_IRWXUGO,
> +		&proc_self_inode_operations, NULL, {}),
> +	{}
> +};

We could save a bunch of bytes here.

> +	/* Lookup the directory entry */
> +	for (p = proc_base_stuff; p->name; p++) {

By using ARRAY_SIZE here.

> +	for (; nr < (ARRAY_SIZE(proc_base_stuff) - 1); filp->f_pos++, nr++) {

like that does.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/