Re: [PATCH libata-dev#upstream-fixes] libata: ignore CFA signaturewhile sanity-checking an ATAPI device

[Jeff Garzik]

Andrew Morton wrote:
> On Thu, 7 Sep 2006 20:32:24 +0900
> Tejun Heo <htejun@xxxxxxxxx> wrote:
>
> > 0x848a in ID word 0 indicates CFA device iff the ID data is obtained
> > from IDENTIFY DEVICE.  For ATAPI devices, 0x848a in ID work 0
> > indicates valid ATAPI device.  Fix sanity check in ata_dev_read_id()
> > such that ATAPI devices reporting 0x848a in ID word 0 is not handled
> > as error.
> >
> > The problem is identified by J.A. Magallon with HL-DT-ST DVDRAM
> > GSA-4120B.
> >
> > Signed-off-by: Tejun Helo <htejun@xxxxxxxxx>
> > Cc: J.A. Magallon <jamagallon@xxxxxxx>
> > ---
> > Jeff, this is a regression and thus should go into .19.
>
> You mean 2.6.18, yes?

Actually, it looks like it should indeed be 2.6.19 (libata #upstream), 
not 2.6.18 (libata #upstream-fixes).  Alan's "add compactflash support" 
patch isn't in 2.6.18-rc.

So, this should -not- be sent for 2.6.18.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/