Re: Spinlock debugging

From: Alan Cox
Date: Tue Sep 12 2006 - 09:38:08 EST


Ar Maw, 2006-09-12 am 17:31 +0400, ysgrifennodd Sergei Organov:
> Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> writes:
> [...]
> > So all you need in your IRQ handler is
> >
> > if (tty_insert_flip_string(tty, buf, size))
> > tty_flip_buffer_push(tty);
>
> What is the purpose of the "if" in the above code? is push with no data
> in the buffer dangerous? Or is it just optimization of
> almost-never-taken path? ;)

Sorry..replied to sender only

It's an optimisation and you are right it may well not even be worth
doing

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/