Re: [PATCH] mxser: PCI refcounts

From: Alan Cox
Date: Sat Sep 16 2006 - 12:45:40 EST


Ar Sad, 2006-09-16 am 14:39 +0159, ysgrifennodd Jiri Slaby:
> Alan Cox wrote:
> > Switch to pci ref counts for mxser when handling PCI devices. Use
> > pci_get_device and drop the reference when we finish and unload.
>
> Please, don't do that. These all drivers need to be rewritten to pci probing
> (for this one I have a patch, but I waited for confirmation of previous
> patchset, but nothing has come, so perhaps I will clone it as NEW/EXPERIMENTAL
> 1.9.1-with-pci-probing-driver) and when pci_find_device is there, we can `grep
> -r` it to know, which drivers need that. The same holds for zoran cards, which
> somebody wanted to play with (and rework), but as I can see, nothing happened :/.

Well if they need pci probing updates perhaps we should either apply the
alternative patches and see what breaks, or delete the driver and see
who screams.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/