Re: [PATCH 4/7] SLIM: secfs patch

From: Dave Jones
Date: Mon Sep 18 2006 - 16:54:46 EST


On Mon, Sep 18, 2006 at 01:50:42PM -0700, Kylene Jo Hall wrote:

> > > This patch provides the securityfs used by SLIM.

nitpick. (I never reviewed this when it was posted, but this followup
caught my eye..)

> > > --- linux-2.6.18/security/slim/slm_secfs.c 1969-12-31 16:00:00.000000000 -0800
> > > +++ linux-2.6.17-working/security/slim/slm_secfs.c 2006-09-06 11:49:09.000000000 -0700
> > > @@ -0,0 +1,73 @@
> > > +/*
> > > + * SLIM securityfs support: debugging control files
> > > + *
> > > + * Copyright (C) 2005, 2006 IBM Corporation
> > > + * Author: Mimi Zohar <zohar@xxxxxxxxxx>
> > > + * Kylene Hall <kjhall@xxxxxxxxxx>
> > > + *
> > > + * This program is free software; you can redistribute it and/or modify
> > > + * it under the terms of the GNU General Public License as published by
> > > + * the Free Software Foundation, version 2 of the License.
> > > + */
> > > +
> > > +#include <asm/uaccess.h>
> > > +#include <linux/config.h>

You don't need to include config.h any more, kbuild does it for you.
(Might want to check the other files for the same thing).

Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/