Re: [linux-usb-devel] [PATCH] USB: consolidate error values fromEHCI, UHCI and OHCI _suspend()

From: Alan Stern
Date: Tue Sep 19 2006 - 16:33:08 EST


On Tue, 19 Sep 2006, David Brownell wrote:

> Eventually we want hcd->state to vanish, but until it does it sure seems
> like a problem if usbcore can't rely on all HCDs to treat it the same.

uhci-hcd sets hcd->state wherever needed by usbcore, just as the other
HCDs do. (At least that was my intention -- if I missed setting it
somewhere then the driver should be fixed.)

But uhci-hcd never reads hcd->state or tests its value. I think that's
what Jiri meant.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/