Re: [RTC] Remove superfluous call to call to cdev_del()

[Alessandro Zummo]

On Thu, 21 Sep 2006 09:46:06 +0200
Rolf Eike Beer <eike-kernel@xxxxxxxxx> wrote:

> If cdev_add() fails there is no good reason to call cdev_del().
> 
> Signed-off-by: Rolf Eike Beer <eike-kernel@xxxxxxxxx>
>
>  	rtc->char_dev.owner = rtc->owner;
>  
>  	if (cdev_add(&rtc->char_dev, MKDEV(MAJOR(rtc_devt), rtc->id), 1)) {
> -		cdev_del(&rtc->char_dev);
>  		dev_err(class_dev->dev,
>  			"failed to add char device %d:%d\n",
>  			MAJOR(rtc_devt), rtc->id);

 I'm not sure.. this is drivers/char/raw.c:


 cdev_init(&raw_cdev, &raw_fops);
        if (cdev_add(&raw_cdev, dev, MAX_RAW_MINORS)) {
                kobject_put(&raw_cdev.kobj);
                unregister_chrdev_region(dev, MAX_RAW_MINORS);
                goto error;
        }

 in case of failure, it does a kobject_put.
 tha same call is done by cdev_del.

 other drivers have implemented different error paths.
 which one is correct?

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Turin, Italy

  http://www.towertech.it

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/