Re: [PATCH 1/2] block: support larger block pc requests take 2

From: Mike Christie
Date: Thu Sep 21 2006 - 15:14:24 EST


Jens Axboe wrote:
> On Thu, Sep 21 2006, Jens Axboe wrote:
>> On Fri, Sep 15 2006, michaelc@xxxxxxxxxxx wrote:
>>> From: Mike Christie <michaelc@xxxxxxxxxxx>
>>>
>>> This patch modifies blk_rq_map/unmap_user() so that it supports
>>> requests larger than bio by chaning them together.
>>>
>>> Changes since v1.
>>> 1. Removed blk_get_bounced_bio() function. blk_rq_unmap_user
>>> checks the bounced flag and if set access bi_private.
>>>
>>> 2. Removed biohead_orig field from request.
>>> Signed-off-by: Mike Christie <michaelc@xxxxxxxxxxx>
>> Patches 1+2 applied, thanks Mike!
>
> Tested, and no good. You can't split it into two patches, if it doesn't
> compile with 1/2 applied. If scsi_ioctl.c needs to be changed, do it
> with the change and not in the next patch. Otherwise bisecting breaks.
>

Ok.

> Care to resubmit? Just combine the two, but split the bsg patch as that

Will do. Just a sec. Downloading from kernel.org is a little slow. I
will send in another thread in case you have some fancy script in a
couple minutes.

> needs to go into a separate branch for now. The bsg patch will just be
> merged into the bsg patch set, as that needs to be based on 'block'
> anyway.
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/