Re: [PATCH 05/16] GFS2: File and inode operations

From: Steven Whitehouse
Date: Fri Sep 22 2006 - 07:02:33 EST


Hi,

On Sat, 2006-09-16 at 14:39 +0100, Christoph Hellwig wrote:
>
> > >+static int gfs2_readdir(struct file *file, void *dirent, filldir_t filldir)
> > >+{
> > >+ int error;
> > >+
> > >+ if (strcmp(current->comm, "nfsd") != 0)
> >
> > Is not there a better way to do this? Note that there is also a "nfsd4" process
>
> This is in fact not allowed at at all. Please fix you readdir code not to
> need special cases for nfsd.
>

This has now been done in the git tree, and I believe that the resulting
lock ordering will be deadlock free,

Steve.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/