Re: /drivers/usb/class/cdc-acm.c patch question, please cc

From: Greg KH
Date: Fri Sep 22 2006 - 18:31:24 EST


On Fri, Sep 22, 2006 at 05:45:21PM -0400, Ryan Moszynski wrote:
> using
> 2.6.18
>
> quick version of this question:
>
> how could i change line 1 to line 2 without breaking anything while
> providing the
> functionality of the patch i'm trying to apply?
>
>
> /* line 1 /drivers/usb/class/cdc-acm.c line 918
> readsize = le16_to_cpu(epread->wMaxPacketSize)* ( quirks ==
> SINGLE_RX_URB ? 1 : 2);
>
> /* line 2
> readsize = (le16_to_cpu(epread->wMaxPacketSize) >
> maxszr)?le16_to_cpu(epread->wMaxPacketSize):maxszr;
>
>
>
>
>
> long version:
>
> since 2.6.14 i have been applying the following patch and recompiling
> my kernel so
> that i can use my verizon kpc650 evdo card with my laptop. I've
> applied this patch
> succesfully on 2.6.14 and 2.6.15. It works great and I have no problems.
> I am
> trying to apply the patch to 2.6.18 but it fails, and i don't want to
> break anything,
> though I do need the functionality of the patch, since evdo is my only form
> of
> internet(i live out in the sticks.) Without this patch, after setting
> up the needed
> config files, i can websurf, but if i try to download anything, the
> connection closes.
>
> The rest of this patch, other than the chunk of which this line is a part,
> applies successfully.

Try the 2.6.18 kernel with no patch, it should have a driver for this
device already.

If not, let me know, and I'll work on something, you should not have to
modify the usb-serial core to get this device to actually use a sane
data rate.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/