Re: 2.6.1[78] page allocation failure. order:3, mode:0x20

From: Andrew Morton
Date: Sat Sep 23 2006 - 00:50:18 EST


On Fri, 22 Sep 2006 10:10:36 -0700
Auke Kok <auke-jan.h.kok@xxxxxxxxx> wrote:

> I wonder if we can't account for NET_IP_ALIGN when selecting bufsize, to get at
> rid of at least 1 order size before we netdev_alloc_skb. This should make 9k
> frames only kmalloc(16384) and thus stay within the 16k boundary. I hope.
>
> Completely untested: don't commit :)
>

I did - I think we want this patch.

>
> e1000: account for NET_IP_ALIGN when calculating bufsiz
>
> Account for NET_IP_ALIGN when requesting buffer sizes from netdev_alloc_skb to
> reduce slab allocation by half.

Could we please do whatever is needed to get this blessed and merged? This
is such a common problem on such a common driver that I would suggest that
we want this in 2.6.18.x as well. At least, I'd expect distributors to
ship this fix (they're nuts if they don't) and so it makes sense to deliver
it from kernel.org.
-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html