Re: [linux-usb-devel] [GIT PATCH] More USB patches for 2.6.18

From: Andrew Morton
Date: Thu Sep 28 2006 - 20:21:09 EST


On Thu, 28 Sep 2006 17:08:33 -0700
David Brownell <david-b@xxxxxxxxxxx> wrote:

> > --- a/drivers/usb/host/ohci-hub.c~ohci-add-auto-stop-support-hack-hack
> > +++ a/drivers/usb/host/ohci-hub.c
> > @@ -132,6 +132,10 @@ static inline struct ed *find_head (stru
> > return ed;
> > }
> >
> > +#ifdef CONFIG_PM
> > +static int ohci_restart(struct ohci_hcd *ohci);
> > +#endif
> > +
> > /* caller has locked the root hub */
>
> Better to just always include the forward decl... much cleaner!

See other email.

> ... reviewing and testing those new OHCI changes is still on my
> list;

erm, we prefer to do that before code hits mainline.

> all that suspend stuff needs care, things that work on PCs don't
> necessarily work on embedded hardware (where OHCI is common, and
> PM tends to be more critical).

I guess we'll find out.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/